Change in osmo-bts[master]: bts_shutdown: First deact RF on all TRX, finally close them

[pespin]

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/18912 )

Change subject: bts_shutdown: First deact RF on all TRX, finally close them
......................................................................

bts_shutdown: First deact RF on all TRX, finally close them

It makes more sense to first deactive RF on all TRX and finally close
them totally. This way we keep consistency between all TRXs and it's
easier for lower layers which may need to close them all at once. Also
in the event that we want to turn bts_model_trx_deact_rf to return
asynchronously.

Change-Id: Ib62358384e37a5cef692926439462042fab0138c
---
M src/common/bts_shutdown_fsm.c
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved



diff --git a/src/common/bts_shutdown_fsm.c b/src/common/bts_shutdown_fsm.c
index faa92a0..e65fff4 100644
--- a/src/common/bts_shutdown_fsm.c
+++ b/src/common/bts_shutdown_fsm.c
@@ -90,6 +90,8 @@
 	struct gsm_bts_trx *trx;
 	llist_for_each_entry_reverse(trx, &bts->trx_list, list) {
 		bts_model_trx_deact_rf(trx);
+	}
+	llist_for_each_entry_reverse(trx, &bts->trx_list, list) {
 		bts_model_trx_close(trx);
 	}
 	/* There's yet no way to get confirmation from lower layers regarding

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/18912
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ib62358384e37a5cef692926439462042fab0138c
Gerrit-Change-Number: 18912
Gerrit-PatchSet: 5
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200623/70fa81bf/attachment.htm>