Change in osmo-bts[master]: Implement tx power ramp down during BTS shutdown

[pespin]

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/18904 )

Change subject: Implement tx power ramp down during BTS shutdown
......................................................................


Patch Set 4:

(2 comments)

https://gerrit.osmocom.org/c/osmo-bts/+/18904/4/src/common/bts_shutdown_fsm.c 
File src/common/bts_shutdown_fsm.c:

https://gerrit.osmocom.org/c/osmo-bts/+/18904/4/src/common/bts_shutdown_fsm.c@51 
PS4, Line 51: osmo_fsm_inst_dispatch
> I guess sending events to the FSM could be done directly, without the need to pass a callback functi […]
It cannot be done directly because that would be a layer violation and in any case there's several users of the ramping callback. So simply let who started the ramping decide what to do when it's done.


https://gerrit.osmocom.org/c/osmo-bts/+/18904/4/src/common/bts_shutdown_fsm.c@59 
PS4, Line 59: 	for (i = 0; i < bts->num_trx; i++) {
> Why not to iterate over the linked list directly? […]
WHy? because I simply copied it from somewhere else in the code.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/18904
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I70e34dda8974ebd94aea33bd9fb1d99f9063cc55
Gerrit-Change-Number: 18904
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: neels <nhofmeyr at sysmocom.de>
Gerrit-Comment-Date: Tue, 23 Jun 2020 12:33:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200623/8c474dc2/attachment.htm>