This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18971 ) Change subject: rtp_fsm, vty: check with is_ipaccess_bts() before using IPACC ...................................................................... Patch Set 1: Code-Review-1 (4 comments) https://gerrit.osmocom.org/c/osmo-bsc/+/18971/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/c/osmo-bsc/+/18971/1//COMMIT_MSG@10 PS1, Line 10: negotiate ip address and port for RTP/VoIP. This protocol is BTS to negotiate https://gerrit.osmocom.org/c/osmo-bsc/+/18971/1//COMMIT_MSG@12 PS1, Line 12: all locations in osmo-bts check the bts type before using IPACC, lets let's https://gerrit.osmocom.org/c/osmo-bsc/+/18971/1/src/osmo-bsc/bsc_vty.c File src/osmo-bsc/bsc_vty.c: https://gerrit.osmocom.org/c/osmo-bsc/+/18971/1/src/osmo-bsc/bsc_vty.c@5138 PS1, Line 5138: if (is_ipaccess_bts(lchan->ts->trx->bts)) so afaiu after your patch, if the bts is not an IPA based one, this VTY cmd does nothing. Wouldn't it make more sense to print and return a warning in that case? https://gerrit.osmocom.org/c/osmo-bsc/+/18971/1/src/osmo-bsc/lchan_rtp_fsm.c File src/osmo-bsc/lchan_rtp_fsm.c: https://gerrit.osmocom.org/c/osmo-bsc/+/18971/1/src/osmo-bsc/lchan_rtp_fsm.c@347 PS1, Line 347: if (is_ipaccess_bts(lchan->ts->trx->bts)) { So if it's not an IPACC, why is it in a "wait_ipacc_mdcx_ack" state in first place? This patch looks like the wrong solution to me. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/18971 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I9ee78b6b1d342abaccc09a87dee6af79e76e5468 Gerrit-Change-Number: 18971 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Tue, 23 Jun 2020 09:38:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200623/5f556fb7/attachment.htm>