This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/18966 ) Change subject: fixup for gsm0808_create_common_id(): add API doc, use new MI API ...................................................................... Patch Set 1: (2 comments) https://gerrit.osmocom.org/c/libosmocore/+/18966/1/src/gsm/gsm0808.c File src/gsm/gsm0808.c: https://gerrit.osmocom.org/c/libosmocore/+/18966/1/src/gsm/gsm0808.c@1238 PS1, Line 1238: /*! Create BSSMAP COMMON ID message, 3GPP TS 48.008 3.2.1.68. thanks, I didn't bother as none of the other gsm0808_ functions I saw had any documentation. But it's a lame ecuse. https://gerrit.osmocom.org/c/libosmocore/+/18966/1/src/gsm/gsm0808.c@1269 PS1, Line 1269: *out = rc; well, I was using the same functions as used a few lines above when generating the GSM0808_IE_IMSI for the BSSMAP PAGING REQUEST. I think if we convert from old to new APIs we should convert all of the old API users in the file at once? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/18966 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I979bca0c6aaa8fe4feddda922bd2e6c1cb49585b Gerrit-Change-Number: 18966 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-CC: laforge <laforge at osmocom.org> Gerrit-Comment-Date: Mon, 22 Jun 2020 18:35:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200622/6ffed558/attachment.htm>