This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/18903 ) Change subject: Introduce bts_shutdown FSM ...................................................................... Patch Set 3: (2 comments) https://gerrit.osmocom.org/c/osmo-bts/+/18903/3/include/osmo-bts/bts_shutdown_fsm.h File include/osmo-bts/bts_shutdown_fsm.h: https://gerrit.osmocom.org/c/osmo-bts/+/18903/3/include/osmo-bts/bts_shutdown_fsm.h@40 PS3, Line 40: struct gsm_bts; > weird to declare an opaque struct without any API in this header requiring it That's a leftover from previous patch, thanks for catching. https://gerrit.osmocom.org/c/osmo-bts/+/18903/3/src/common/gsm_data.c File src/common/gsm_data.c: https://gerrit.osmocom.org/c/osmo-bts/+/18903/3/src/common/gsm_data.c@295 PS3, Line 295: LOGL_INFO, bts_name); > (possible without a char buffer: […] Regarding global pointers vs using structs, I always prefer keeping stuff referenced in a tree rather than having more and more global variables. Regarding why bts0: because we use numbers in VTY for bts object too. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/18903 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I8f48f17e61c3b9b86342eaf5b8a2b1ac9758bde5 Gerrit-Change-Number: 18903 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-CC: neels <nhofmeyr at sysmocom.de> Gerrit-Comment-Date: Mon, 22 Jun 2020 17:44:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200622/99f2133e/attachment.htm>