This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/18903 ) Change subject: Introduce bts_shutdown FSM ...................................................................... Patch Set 2: > Patch Set 2: > > would it make sense to have one "ramp" FSM that handles both ramping up and ramping down? It would make sense if we had to rewrite the ramping code from 0, but since the current tx_power.c ramping code is modular/enclosed enough, I'd say it's not worth spending time into moving that to an FSM right now and having to verify it everywhere. I simply needed to do some small fixes and add a "finished" callback and it's enough for now. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/18903 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I8f48f17e61c3b9b86342eaf5b8a2b1ac9758bde5 Gerrit-Change-Number: 18903 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-CC: laforge <laforge at osmocom.org> Gerrit-Comment-Date: Mon, 22 Jun 2020 09:34:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200622/1e153ae4/attachment.htm>