Change in libosmo-sccp[master]: M3UA: Accept DATA without routing context IE if only a single AS in ASP

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Sun Jun 21 16:06:28 UTC 2020


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/18818 )

Change subject: M3UA: Accept DATA without routing context IE if only a single AS in ASP
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/c/libosmo-sccp/+/18818/1/src/m3ua.c 
File src/m3ua.c:

https://gerrit.osmocom.org/c/libosmo-sccp/+/18818/1/src/m3ua.c@590 
PS1, Line 590: 			LOGPASP(asp, DLM3UA, LOGL_ERROR,
> I don't think we really need to pass __func__ here, it's avilable already through the log macros.
really? We only log the file and line number, AFAIR.  And I'm just using the same style as in the existing code I'm modifying...



-- 
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/18818
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: I59f47a999f40411aadc88b8f362d8d2b89a66332
Gerrit-Change-Number: 18818
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Sun, 21 Jun 2020 16:06:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200621/c79e3729/attachment.htm>


More information about the gerrit-log mailing list