This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
neels gerrit-no-reply at lists.osmocom.orgneels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18846 ) Change subject: bsc: allow individual T_guard timeout via f_init() ...................................................................... bsc: allow individual T_guard timeout via f_init() The TC_ho_neighbor_config_* tests sometimes take longer than 30 seconds, because they run multiple handovers. Since they don't have access to the Test_CT, they cannot restart the T_guard. The simplest solution is to choose a longer T_guard timeout for those tests specifically, by adding an argument to f_init(). (A longer timeout for those tests is following in another patch.) Why f_init()? Assigning a different default value to T_guard seems to not be possible, but a different timeout value can be passed to T_guard.start(), which happens in f_init(). Change-Id: I14918f6a44d6fa1bd5c3e133757ebdbe32813b33 --- M bsc/BSC_Tests.ttcn 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index 485411b..f0117ed 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -104,7 +104,7 @@ /*Configure T(tiar) over VTY, seconds */ var integer g_bsc_sccp_timer_iar := 15 * 60; - /* global test case guard timer */ + /* global test case guard timer (actual timeout value is set in f_init()) */ timer T_guard := 30.0; } @@ -384,7 +384,7 @@ * \param nr_msc Number of virtual MSCs to bring up to connect to osmo-bsc. */ function f_init(integer nr_bts := NUM_BTS, boolean handler_mode := false, boolean allow_osmux := false, - integer nr_msc := 1) runs on test_CT { + integer nr_msc := 1, float guard_timeout := 30.0) runs on test_CT { var integer bssap_idx; var integer i; @@ -393,7 +393,7 @@ } g_initialized := true; - T_guard.start; + T_guard.start(guard_timeout); activate(as_Tguard()); f_init_vty("VirtMSC"); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18846 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I14918f6a44d6fa1bd5c3e133757ebdbe32813b33 Gerrit-Change-Number: 18846 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200620/38d366f6/attachment.htm>