Change in osmo-bts[master]: Introduce bts_shutdown FSM

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Thu Jun 18 22:53:59 UTC 2020


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/18903 )

Change subject: Introduce bts_shutdown FSM
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.osmocom.org/c/osmo-bts/+/18903/1/include/osmo-bts/bts_shutdown_fsm.h 
File include/osmo-bts/bts_shutdown_fsm.h:

https://gerrit.osmocom.org/c/osmo-bts/+/18903/1/include/osmo-bts/bts_shutdown_fsm.h@41 
PS1, Line 41: bts_shutdown
> I explicitly moved it here since I prefer having everything shutdown related in one file. […]
But this way it's inconsistent: you have bts_init() and other bts_* API in one header, and moving bts_shutdown() to another. One more problem is that you're basically exposing access to the shutdown FSM internals, but none of the files where you include this header, deal with the FSM directly. Neither they send events, nor check the state. They just invoke the ramp_down_compl_cb() that will be introduced in the next change.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/18903
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I8f48f17e61c3b9b86342eaf5b8a2b1ac9758bde5
Gerrit-Change-Number: 18903
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 18 Jun 2020 22:53:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200618/f0ae42d0/attachment.htm>


More information about the gerrit-log mailing list