Change in osmo-bts[master]: bts_shutdown: First deact RF on all TRX, finally close them

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Thu Jun 18 18:01:18 UTC 2020


pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/18912 )


Change subject: bts_shutdown: First deact RF on all TRX, finally close them
......................................................................

bts_shutdown: First deact RF on all TRX, finally close them

It makes more sense to first deactive RF on all TRX and finally close
them totally. This way we keep consistency between all TRXs and it's
easier for lower layers which may need to close them all at once. Also
in the event that we want to turn bts_model_trx_deact_rf to return
asynchronously.

Change-Id: Ib62358384e37a5cef692926439462042fab0138c
---
M src/common/bts_shutdown_fsm.c
1 file changed, 2 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/12/18912/1

diff --git a/src/common/bts_shutdown_fsm.c b/src/common/bts_shutdown_fsm.c
index df22284..6fddcc0 100644
--- a/src/common/bts_shutdown_fsm.c
+++ b/src/common/bts_shutdown_fsm.c
@@ -93,6 +93,8 @@
 	struct gsm_bts_trx *trx;
 	llist_for_each_entry_reverse(trx, &bts->trx_list, list) {
 		bts_model_trx_deact_rf(trx);
+	}
+	llist_for_each_entry_reverse(trx, &bts->trx_list, list) {
 		bts_model_trx_close(trx);
 	}
 	/* There's yet no way to get confirmation from lower layers regarding

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/18912
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ib62358384e37a5cef692926439462042fab0138c
Gerrit-Change-Number: 18912
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200618/daf0553a/attachment.htm>


More information about the gerrit-log mailing list