This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
dexter gerrit-no-reply at lists.osmocom.orgdexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/18898 ) Change subject: endp: add E1 endpoint interlocking ...................................................................... Patch Set 2: (3 comments) > Patch Set 1: Code-Review-1 > > (4 comments) > > I don't really see the point in storing a bunch of properties in a string and then having to parse them from there everytime. Am I missing something which really requires this way of doing stuff? The reason why I do this is because I want the properties to be stored in the string only instead of having a bunch of additional struct members that hold some values that need to be consistent with the string. I prefer to have more code and get a less ambiguous model in return. https://gerrit.osmocom.org/c/osmo-mgw/+/18898/1/src/libosmo-mgcp/mgcp_endp.c File src/libosmo-mgcp/mgcp_endp.c: https://gerrit.osmocom.org/c/osmo-mgw/+/18898/1/src/libosmo-mgcp/mgcp_endp.c@374 PS1, Line 374: static uint8_t e1_ts_nr_from_epname(char *epname) > Did you think about simply storing all this information as integers in the endp struct during endp c […] Yes, that is intentional, I want this information to be in the endpoint string only since that is the handle that should be used for everything. I think we can afford the string processing. https://gerrit.osmocom.org/c/osmo-mgw/+/18898/1/src/libosmo-mgcp/mgcp_endp.c@568 PS1, Line 568: for(i=0;i<15;i++) { > spacing Done https://gerrit.osmocom.org/c/osmo-mgw/+/18898/1/src/libosmo-mgcp/mgcp_endp.c@607 PS1, Line 607: /* There are no obsticels that may render a virtual trunk > typo: obsticels Done -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/18898 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I18e90b10648a7e504371179ad144645fc82e1c27 Gerrit-Change-Number: 18898 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Thu, 18 Jun 2020 13:06:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200618/dde46f99/attachment.htm>