Change in osmo-mgw[master]: libosmo-mgcp-client: fix use-after-free in mgcp_msg_gen()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Thu Jun 18 11:40:38 UTC 2020


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/18891 )

Change subject: libosmo-mgcp-client: fix use-after-free in mgcp_msg_gen()
......................................................................

libosmo-mgcp-client: fix use-after-free in mgcp_msg_gen()

Change-Id: Ib8b6c25489a6a704912aa1763d7430c8055d54e3
---
M src/libosmo-mgcp-client/mgcp_client.c
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/libosmo-mgcp-client/mgcp_client.c b/src/libosmo-mgcp-client/mgcp_client.c
index e9b3ec0..54db20d 100644
--- a/src/libosmo-mgcp-client/mgcp_client.c
+++ b/src/libosmo-mgcp-client/mgcp_client.c
@@ -1208,6 +1208,7 @@
 			     "Endpoint name (%s) lacks separator (@), can not generate MGCP message\n",
 			     mgcp_msg->endpoint);
 			msgb_free(msg);
+			return NULL;
 		}
 
 		rc += msgb_printf(msg, " %s", mgcp_msg->endpoint);

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/18891
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: Ib8b6c25489a6a704912aa1763d7430c8055d54e3
Gerrit-Change-Number: 18891
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200618/0ca34813/attachment.htm>


More information about the gerrit-log mailing list