This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18888 ) Change subject: sgsn: Add functions for BSSGP suspend + resume procedure ...................................................................... Patch Set 1: Code-Review+2 (1 comment) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18888/1/sgsn/SGSN_Tests.ttcn File sgsn/SGSN_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18888/1/sgsn/SGSN_Tests.ttcn@812 PS1, Line 812: setverdict(fail, "SUSPEND-NACK in response to SUSPEND for TLLI ", g_pars.tlli); > mtc.stop; missing in all failures. the question is: do we want that? I think it's a bit of a philosophical question if we should terminate at the first failure or if we should continue running the test. I think in my code in general I tend to do the latter. Not saying it makes sense, just saying I don't think we have a universally agreed-upon style here. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18888 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib1e370e2c5fe774029f459ef991fb9ac777f5631 Gerrit-Change-Number: 18888 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge at osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Thu, 18 Jun 2020 11:30:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200618/3b3141ec/attachment.htm>