Change in osmo-mgw[master]: endp: add E1 endpoint interlocking

[pespin]

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/18898 )

Change subject: endp: add E1 endpoint interlocking
......................................................................


Patch Set 1: Code-Review-1

(4 comments)

I don't really see the point in storing a bunch of properties in a string and then having to parse them from there everytime. Am I missing something which really requires this way of doing stuff?

https://gerrit.osmocom.org/c/osmo-mgw/+/18898/1//COMMIT_MSG 
Commit Message:

https://gerrit.osmocom.org/c/osmo-mgw/+/18898/1//COMMIT_MSG@11 
PS1, Line 11: withi nthe timeslot. When the equipment (BSC) is properly configured,
typo: within the


https://gerrit.osmocom.org/c/osmo-mgw/+/18898/1/src/libosmo-mgcp/mgcp_endp.c 
File src/libosmo-mgcp/mgcp_endp.c:

https://gerrit.osmocom.org/c/osmo-mgw/+/18898/1/src/libosmo-mgcp/mgcp_endp.c@374 
PS1, Line 374: static uint8_t e1_ts_nr_from_epname(char *epname)
Did you think about simply storing all this information as integers in the endp struct during endp creation instead of having to do string processing everytime?


https://gerrit.osmocom.org/c/osmo-mgw/+/18898/1/src/libosmo-mgcp/mgcp_endp.c@568 
PS1, Line 568: 	for(i=0;i<15;i++) {
spacing


https://gerrit.osmocom.org/c/osmo-mgw/+/18898/1/src/libosmo-mgcp/mgcp_endp.c@607 
PS1, Line 607: 		/* There are no obsticels that may render a virtual trunk
typo: obsticels



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/18898
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: I18e90b10648a7e504371179ad144645fc82e1c27
Gerrit-Change-Number: 18898
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 18 Jun 2020 11:15:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200618/21dee8e9/attachment.htm>