Change in osmo-mgw[master]: trunk: parse E1 trunk number

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Thu Jun 18 11:08:33 UTC 2020


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/18752 )

Change subject: trunk: parse E1 trunk number
......................................................................


Patch Set 5:

(1 comment)

https://gerrit.osmocom.org/c/osmo-mgw/+/18752/5/src/libosmo-mgcp/mgcp_trunk.c 
File src/libosmo-mgcp/mgcp_trunk.c:

https://gerrit.osmocom.org/c/osmo-mgw/+/18752/5/src/libosmo-mgcp/mgcp_trunk.c@142 
PS5, Line 142: 		if (errno == ERANGE || trunk_nr > 64 || trunk_nr == 0)
I recommended checking existing uses of strtoul in osmo-mgw since correctness checking is a bit tricky but seems you didn't follow it?

135:            char *pt_end;
161-            errno = 0;
162-            pt = strtoul(pt_str, &pt_end, 0);
163:            if ((errno == ERANGE && pt == ULONG_MAX) || (errno && !pt) ||
164-                pt_str == pt_end)
165-                    goto error;



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/18752
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: Ifdaab953544151e73b58cc3e95d21afdb40765f4
Gerrit-Change-Number: 18752
Gerrit-PatchSet: 5
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 18 Jun 2020 11:08:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200618/7c928d11/attachment.htm>


More information about the gerrit-log mailing list