This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18765 ) Change subject: MSC pooling: make NRI mappings VTY configurable ...................................................................... Patch Set 6: (5 comments) Mostly cosmetic comments. https://gerrit.osmocom.org/c/osmo-bsc/+/18765/6/src/osmo-bsc/bsc_vty.c File src/osmo-bsc/bsc_vty.c: https://gerrit.osmocom.org/c/osmo-bsc/+/18765/6/src/osmo-bsc/bsc_vty.c@2074 PS6, Line 2074: for MSC pooling Idea: maybe it makes sense to group all NRI related parameters into a separate node, like 'msc-pooling'? So there would be no need to clarify that this particular option is 'for MSC pooling'. https://gerrit.osmocom.org/c/osmo-bsc/+/18765/6/src/osmo-bsc/bsc_vty.c@2085 PS6, Line 2085: (always starting just after the TMSI's most significant octet) IMHO, such technical details should not be here. If the NRI position is defined by the specs., then it's definitely redundant information. https://gerrit.osmocom.org/c/osmo-bsc/+/18765/6/src/osmo-bsc/bsc_vty.c@2086 PS6, Line 2086: bit Cosmetic: s/bit/Bit/ https://gerrit.osmocom.org/c/osmo-bsc/+/18765/6/src/osmo-bsc/osmo_bsc_vty.c File src/osmo-bsc/osmo_bsc_vty.c: https://gerrit.osmocom.org/c/osmo-bsc/+/18765/6/src/osmo-bsc/osmo_bsc_vty.c@801 PS6, Line 801: LOGP Does it really make sense to duplicate the logging? This is not something we usually do. https://gerrit.osmocom.org/c/osmo-bsc/+/18765/6/src/osmo-bsc/osmo_bsc_vty.c@904 PS6, Line 904: CMD_SUCCESS CMD_WARNING? -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/18765 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I6c251f2744d7be26fc4ad74adefc96a6a3fe08b0 Gerrit-Change-Number: 18765 Gerrit-PatchSet: 6 Gerrit-Owner: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann at sysmocom.de> Gerrit-Reviewer: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-CC: fixeria <vyanitskiy at sysmocom.de> Gerrit-Comment-Date: Wed, 17 Jun 2020 18:44:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200617/0cfba62b/attachment.htm>