Change in osmo-bts[master]: scheduler: Add rate_ctr informing about not Dl block not found

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Tue Jun 16 14:48:23 UTC 2020


pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/18863 )


Change subject: scheduler: Add rate_ctr informing about not Dl block not found
......................................................................

scheduler: Add rate_ctr informing about not Dl block not found

Together with previous counter L1SCHED_TS_CTR_DL_LATE, it allows
understanding which dl blocks are really lost (never queued) and which
were simply queued too late.

Change-Id: I456d0cfbef1e03b147ce7d968a3ec42dd728fe74
---
M src/common/scheduler.c
1 file changed, 5 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/63/18863/1

diff --git a/src/common/scheduler.c b/src/common/scheduler.c
index 6d9e132..635562f 100644
--- a/src/common/scheduler.c
+++ b/src/common/scheduler.c
@@ -566,11 +566,13 @@
 
 enum {
 	L1SCHED_TS_CTR_DL_LATE,
+	L1SCHED_TS_CTR_DL_NOT_FOUND,
 };
 
 
 static const struct rate_ctr_desc l1sched_ts_ctr_desc[] = {
 	[L1SCHED_TS_CTR_DL_LATE] =	{"l1sched_ts:dl_late", "Downlink frames prepared too late to submit to lower layers"},
+	[L1SCHED_TS_CTR_DL_NOT_FOUND] =	{"l1sched_ts:dl_not_found", "Downlink frame not found while scheduling"},
 };
 static const struct rate_ctr_group_desc l1sched_ts_ctrg_desc = {
 	"l1sched_ts",
@@ -699,7 +701,7 @@
 			continue;
 		}
 		if (prim_fn > 0) /* l1sap_fn > fn */
-			return NULL;
+			goto not_found;
 
 		/* l1sap_fn == fn */
 		if ((chan_nr ^ (trx_chan_desc[chan].chan_nr | tn))
@@ -715,6 +717,8 @@
 		return msg;
 	}
 
+not_found:
+	rate_ctr_inc2(l1ts->ctrs, L1SCHED_TS_CTR_DL_NOT_FOUND);
 	return NULL;
 
 free_msg:

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/18863
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I456d0cfbef1e03b147ce7d968a3ec42dd728fe74
Gerrit-Change-Number: 18863
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200616/a21062ca/attachment.htm>


More information about the gerrit-log mailing list