This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18765 ) Change subject: MSC pooling: make NRI mappings VTY configurable ...................................................................... Patch Set 3: (1 comment) https://gerrit.osmocom.org/c/osmo-bsc/+/18765/3/src/osmo-bsc/bsc_vty.c File src/osmo-bsc/bsc_vty.c: https://gerrit.osmocom.org/c/osmo-bsc/+/18765/3/src/osmo-bsc/bsc_vty.c@2094 PS3, Line 2094: FIRST [LAST] I'm not sure if this FIRST / LAST (generic variables that accept any kind of string) is the best here. We typically express numeric values in the VTY syntax so the VTY will already reject any kind of unexpected/unknown value. I guess the rationale here is to be able to specify them as both decimal and hex. But is this really a good idea? Isn't it more confusing if there are multiple options? Especially as I'm sure if you enter it as hex it will be saved as integer (or vice-versa?) -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/18765 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I6c251f2744d7be26fc4ad74adefc96a6a3fe08b0 Gerrit-Change-Number: 18765 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann at sysmocom.de> Gerrit-Reviewer: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Tue, 16 Jun 2020 11:03:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200616/31eec57c/attachment.htm>