Change in osmo-ttcn3-hacks[master]: library/RSL_Types: fix RSL_IE_BS_Power: Power Level is 4 bit long

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Tue Jun 16 08:28:36 UTC 2020


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18841 )

Change subject: library/RSL_Types: fix RSL_IE_BS_Power: Power Level is 4 bit long
......................................................................

library/RSL_Types: fix RSL_IE_BS_Power: Power Level is 4 bit long

Unlike the RSL_IE_MS_Power, where power_level is 5 bit long, in
the RSL_IE_BS_Power it's 4 bit long. Fix this.

Change-Id: Ic0cb2275ef585754b9ae5e3d8077ca652afd9365
---
M bts/BTS_Tests.ttcn
M library/RSL_Types.ttcn
2 files changed, 7 insertions(+), 7 deletions(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved



diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn
index b098fc6..f98419d 100644
--- a/bts/BTS_Tests.ttcn
+++ b/bts/BTS_Tests.ttcn
@@ -1697,7 +1697,7 @@
 	boolean toa256_enabled,
 	MeasElemFS meas_ul,
 	int16_t timing_offset_256syms,
-	uint5_t bs_power_level,
+	uint4_t bs_power_level,
 	uint5_t ms_power_level,
 	uint8_t ms_actual_ta
 }
@@ -2129,7 +2129,7 @@
 		f_trxc_fake_toffs256(g_pars.l1_pars.timing_offset_256syms);
 	}
 
-	var uint5_t pwr_var := 1;
+	var uint4_t pwr_var := 1;
 	var template (value) RSL_IE_BS_Power bs_power := ts_RSL_IE_BS_Power(pwr_var);
 	var template (value) RSL_IE pwr := t_RSL_IE(RSL_IE_BS_POWER, RSL_IE_Body:{bs_power := bs_power});
 
@@ -2152,7 +2152,7 @@
 		f_trxc_fake_toffs256(g_pars.l1_pars.timing_offset_256syms);
 	}
 
-	var uint5_t pwr_var := 1;
+	var uint4_t pwr_var := 1;
 	var template (value) RSL_IE_BS_Power bs_power := ts_RSL_IE_BS_Power(pwr_var);
 
 	f_est_dchan();
diff --git a/library/RSL_Types.ttcn b/library/RSL_Types.ttcn
index 77b4e79..af01c5d 100644
--- a/library/RSL_Types.ttcn
+++ b/library/RSL_Types.ttcn
@@ -386,15 +386,15 @@
 		coding_alg_rate := alg
 	}
 
-	/* 9.3.4 */
+	/* 9.3.4 BS Power IE */
 	type record RSL_IE_BS_Power {
-		uint1_t 	reserved,
+		uint2_t 	reserved,
 		boolean		epc,
 		boolean		fpc,
-		uint5_t		power_level
+		uint4_t		power_level
 	}
 
-	template (value) RSL_IE_BS_Power ts_RSL_IE_BS_Power(uint5_t power_level,
+	template (value) RSL_IE_BS_Power ts_RSL_IE_BS_Power(uint4_t power_level,
 							    boolean epc := false, boolean fpc := false) := {
 		reserved := 0,
 		epc := epc,

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18841
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ic0cb2275ef585754b9ae5e3d8077ca652afd9365
Gerrit-Change-Number: 18841
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200616/f7d7aa17/attachment.htm>


More information about the gerrit-log mailing list