Change in osmo-trx[master]: prbs tool: add missing talloc lib

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Mon Jun 15 13:56:01 UTC 2020


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/18830 )

Change subject: prbs tool: add missing talloc lib
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/osmo-trx/+/18830/1/utils/Makefile.am 
File utils/Makefile.am:

https://gerrit.osmocom.org/c/osmo-trx/+/18830/1/utils/Makefile.am@9 
PS1, Line 9: osmo_prbs_tool_LDADD = $(LIBOSMOCODING_LIBS) -ltalloc
The main problem here is that it's not including LIBOSMOCORE, but I see lots of headers osmocom/core in prbs-tool.c:
#include <osmocom/core/bits.h>
#include <osmocom/core/utils.h>
#include <osmocom/core/prbs.h>
#include <osmocom/core/socket.h>
#include <osmocom/gsm/gsm_utils.h>

prbs-tool is not using talloc directly afaict:
$ grep -c talloc ./utils/prbs-tool.c
0

Maybe there's an extra issue with libosmocoding requiring talloc but not having it in its pkgconfig file?



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/18830
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: Ica87cc796978528f1b33002420b582d6e4773349
Gerrit-Change-Number: 18830
Gerrit-PatchSet: 1
Gerrit-Owner: Hoernchen <ewild at sysmocom.de>
Gerrit-CC: Jenkins Builder
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 15 Jun 2020 13:56:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200615/678b57e4/attachment.htm>


More information about the gerrit-log mailing list