This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
neels gerrit-no-reply at lists.osmocom.orgneels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18712 ) Change subject: remove extract_sub(), add bsc_subscr_find_or_create_by_mi() ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/c/osmo-bsc/+/18712/2/include/osmocom/bsc/bsc_subscriber.h File include/osmocom/bsc/bsc_subscriber.h: https://gerrit.osmocom.org/c/osmo-bsc/+/18712/2/include/osmocom/bsc/bsc_subscriber.h@11 PS2, Line 11: struct osmo_mobile_identity; > Can we please include structs from header files instead of leaving potentially dangling definitions […] it is good to avoid as many #include as possible in .h files, and to #include headers in .c files instead, Reason being: smaller compile units (from less includes) and helping to avoid circular header dependencies. but I including a header from an entirely other library of course has no danger of circular includes, and naming the header can make it more clear where it's coming from. I still kind of prefer less #includes in .h, you get the entire picture in the .c anyway. avoiding evangelism here, have your #include then. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/18712 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id6cccaac64392b737b3bba8f3a22a88009adb23b Gerrit-Change-Number: 18712 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de> Gerrit-CC: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Mon, 15 Jun 2020 01:36:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200615/d06cc647/attachment.htm>