This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18758 ) Change subject: fix f_enc_IMEI_L3() oddevenIndicator ...................................................................... Patch Set 1: (2 comments) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18758/1/library/L3_Templates.ttcn File library/L3_Templates.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18758/1/library/L3_Templates.ttcn@184 PS1, Line 184: f_enc_IMEI_L3 I would expect that this function (like other f_enc_* ones) actually does some encoding and returns an octetstring. This is confusing. Maybe we should rather introduce a template, if it does not exist yet? https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18758/1/library/L3_Templates.ttcn@186 PS1, Line 186: var integer len := lengthof(digits); This variable becomes unused. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18758 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iaa9ba1214c4c15fd9620e68fe2e842fdf52912c0 Gerrit-Change-Number: 18758 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-CC: fixeria <vyanitskiy at sysmocom.de> Gerrit-Comment-Date: Thu, 11 Jun 2020 11:41:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200611/affff792/attachment.htm>