This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
neels gerrit-no-reply at lists.osmocom.orgneels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/18755 ) Change subject: endp: add typeset for e1-endpoints ...................................................................... Patch Set 1: Code-Review-1 (4 comments) https://gerrit.osmocom.org/c/osmo-mgw/+/18755/1/include/osmocom/mgcp/mgcp_internal.h File include/osmocom/mgcp/mgcp_internal.h: https://gerrit.osmocom.org/c/osmo-mgw/+/18755/1/include/osmocom/mgcp/mgcp_internal.h@277 PS1, Line 277: void mgcp_cleanup_e1_bridge_cb(struct mgcp_endpoint *endp, struct mgcp_conn *conn); personally I'd put the e1 functions in a separate block, not interleaved in the rtp ones. https://gerrit.osmocom.org/c/osmo-mgw/+/18755/1/src/libosmo-mgcp/mgcp_endp.c File src/libosmo-mgcp/mgcp_endp.c: https://gerrit.osmocom.org/c/osmo-mgw/+/18755/1/src/libosmo-mgcp/mgcp_endp.c@37 PS1, Line 37: .e1.cleanup_cb = mgcp_cleanup_e1_bridge_cb, (personally I'd write .e1 = { .max_conns = 1, .dispatch... } ) https://gerrit.osmocom.org/c/osmo-mgw/+/18755/1/src/libosmo-mgcp/mgcp_network.c File src/libosmo-mgcp/mgcp_network.c: https://gerrit.osmocom.org/c/osmo-mgw/+/18755/1/src/libosmo-mgcp/mgcp_network.c@1332 PS1, Line 1332: * \param[in] proto protocol (MGCP_CONN_TYPE_RTP or MGCP_CONN_TYPE_RTCP) please explain how E1 and RTP / RTCP go together. They don't right? https://gerrit.osmocom.org/c/osmo-mgw/+/18755/1/src/libosmo-mgcp/mgcp_network.c@1368 PS1, Line 1368: * \returns 0 on success, -1 on ERROR. */ there is no return -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/18755 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I68b719a906e8f7251f0ca8c74ceec73bc40376f7 Gerrit-Change-Number: 18755 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de> Gerrit-Comment-Date: Wed, 10 Jun 2020 20:09:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200610/4cb3e067/attachment.htm>