Change in osmo-mgw[master]: endp: add name generator function for E1 endpoints

[neels]

neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/18745 )

Change subject: endp: add name generator function for E1 endpoints
......................................................................


Patch Set 4: Code-Review-1

(2 comments)

https://gerrit.osmocom.org/c/osmo-mgw/+/18745/4/include/osmocom/mgcp_client/mgcp_common.h 
File include/osmocom/mgcp_client/mgcp_common.h:

https://gerrit.osmocom.org/c/osmo-mgw/+/18745/4/include/osmocom/mgcp_client/mgcp_common.h@5 
PS4, Line 5:    This is an automatic copy of <osmocom/mgcp/mgcp_common.h>
I get the feeling you added this file by accident


https://gerrit.osmocom.org/c/osmo-mgw/+/18745/4/src/libosmo-mgcp/mgcp_endp.c 
File src/libosmo-mgcp/mgcp_endp.c:

https://gerrit.osmocom.org/c/osmo-mgw/+/18745/4/src/libosmo-mgcp/mgcp_endp.c@51 
PS4, Line 51: 	    { 0, 4, 0, 2, 4, 6, 0, 1, 2, 3, 4, 5, 6, 7 };
(interesting magic, maybe a comment pointing at where this comes from would be nice)



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/18745
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: I70e0c3f96aa3947165f9926666815ee5614c8f57
Gerrit-Change-Number: 18745
Gerrit-PatchSet: 4
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 10 Jun 2020 20:00:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200610/38ecbf42/attachment.htm>