Change in osmo-pcu[master]: bts: add send_gsmtap_rach(), also send PTCCH/U over GSMTAP

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Wed Jun 10 18:14:10 UTC 2020


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/17708 )

Change subject: bts: add send_gsmtap_rach(), also send PTCCH/U over GSMTAP
......................................................................


Patch Set 2: Code-Review+1

(2 comments)

https://gerrit.osmocom.org/c/osmo-pcu/+/17708/2/src/bts.h 
File src/bts.h:

https://gerrit.osmocom.org/c/osmo-pcu/+/17708/2/src/bts.h@340 
PS2, Line 340: 	void send_gsmtap_rach(const struct rach_ind_params *rip,
You could keep categ as first param, like in the other 2 functions.


https://gerrit.osmocom.org/c/osmo-pcu/+/17708/2/src/bts.cpp 
File src/bts.cpp:

https://gerrit.osmocom.org/c/osmo-pcu/+/17708/2/src/bts.cpp@437 
PS2, Line 437: 	send_gsmtap(categ, true, rip->trx_nr, rip->ts_nr, gsmtap_chan,
I'd really prefer it calling send_gsmtap_meas directly in order to avoid yet another function call:
send_gsmtap_rach -> send_gsmtap -> send_gsmtap_meas 

Otherwise it's already confusing.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/17708
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I5cc4c3d2522215a31924121f83fcc2ac9ac6fe9c
Gerrit-Change-Number: 17708
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 10 Jun 2020 18:14:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200610/51902a67/attachment.htm>


More information about the gerrit-log mailing list