Change in osmocom-bb[master]: trxcon: fix potential buffer overflow in l1ctl_proc_est_req_h1()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Wed Jun 10 17:04:39 UTC 2020


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/18542 )

Change subject: trxcon: fix potential buffer overflow in l1ctl_proc_est_req_h1()
......................................................................


Patch Set 2: Code-Review+2

(1 comment)

https://gerrit.osmocom.org/c/osmocom-bb/+/18542/2/src/host/trxcon/l1ctl.c 
File src/host/trxcon/l1ctl.c:

https://gerrit.osmocom.org/c/osmocom-bb/+/18542/2/src/host/trxcon/l1ctl.c@610 
PS2, Line 610: 		LOGP(DL1C, LOGL_ERROR, "More than 64 channels in mobile allocation?!?\n");
> rather write the actual "%lu", ARRAY_SIZE(ma) than hardode "64"
It's always 64 according to the specs., so I don't think it's critical. I mean it's not just a maximum that we support.



-- 
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/18542
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I10f03ca66412a4a7094b0f4a7319411d5d5818ef
Gerrit-Change-Number: 18542
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 10 Jun 2020 17:04:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: neels <nhofmeyr at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200610/5e74f456/attachment.htm>


More information about the gerrit-log mailing list