This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/18754 ) Change subject: endp: move endpoint name generation into mgcp_endp.c ...................................................................... Patch Set 1: (4 comments) https://gerrit.osmocom.org/c/osmo-mgw/+/18754/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/c/osmo-mgw/+/18754/1//COMMIT_MSG@21 PS1, Line 21: endpoint will name itsself by the trunk properites and the index number typo: properties https://gerrit.osmocom.org/c/osmo-mgw/+/18754/1/include/osmocom/mgcp/mgcp_endp.h File include/osmocom/mgcp/mgcp_endp.h: https://gerrit.osmocom.org/c/osmo-mgw/+/18754/1/include/osmocom/mgcp/mgcp_endp.h@107 PS1, Line 107: unsigned int index); no need to split new line https://gerrit.osmocom.org/c/osmo-mgw/+/18754/1/src/libosmo-mgcp/mgcp_endp.c File src/libosmo-mgcp/mgcp_endp.c: https://gerrit.osmocom.org/c/osmo-mgw/+/18754/1/src/libosmo-mgcp/mgcp_endp.c@65 PS1, Line 65: gen_virtual_epname(ep_name_buf, trunk->cfg->domain, index); It's a bit strange having a function for one type while still using snprintf directly here for another. https://gerrit.osmocom.org/c/osmo-mgw/+/18754/1/src/libosmo-mgcp/mgcp_endp.c@78 PS1, Line 78: endp->name = talloc_strdup(endp, ep_name_buf); What about using talloc_asprintf() instead of snprintf + talloc_strdup? -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/18754 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I8dee07f1c63037d1f73113f69c612d1f2703cee5 Gerrit-Change-Number: 18754 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Wed, 10 Jun 2020 14:13:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200610/ea950254/attachment.htm>