This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18535 ) Change subject: ms_srs: refactor UE state getter functions ...................................................................... Patch Set 7: (2 comments) https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18535/7/src/osmo_gsm_tester/obj/ms.py File src/osmo_gsm_tester/obj/ms.py: https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18535/7/src/osmo_gsm_tester/obj/ms.py@82 PS7, Line 82: ''' Checks wheter MS is registered with core network and has optained an IP, If MCC/MNC are given it check for this ''' extra whitespace. typo: whether. typo: optained. BTW, in 2G being registered doesn't mean you have an IP address. So I would describe generally this method as: '''Check whether MS is considered registered with the target network. In 2G networks, and MS is registered if it had a successful Location Update in CS. In 4G networks, an UE is considered registered with the core network if it has obtained and IP address. If MCC/MNC are given it tries to manually register against that specific network.''' https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18535/7/src/osmo_gsm_tester/obj/ms_srs.py File src/osmo_gsm_tester/obj/ms_srs.py: https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18535/7/src/osmo_gsm_tester/obj/ms_srs.py@310 PS7, Line 310: def is_rrc_idle(self): AS requested please drop this API. It will really ease maintainership. -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18535 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: I6cd057e34b4df6a1a73695355dd6406d7e039546 Gerrit-Change-Number: 18535 Gerrit-PatchSet: 7 Gerrit-Owner: srs_andre <andre at softwareradiosystems.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Reviewer: srs_andre <andre at softwareradiosystems.com> Gerrit-Comment-Date: Wed, 10 Jun 2020 11:35:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200610/e5e662a4/attachment.htm>