Change in osmocom-bb[master]: firmware/apps/rssi: enlarge text buffer in refresh_display()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Tue Jun 9 15:52:06 UTC 2020


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/18747 )

Change subject: firmware/apps/rssi: enlarge text buffer in refresh_display()
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/c/osmocom-bb/+/18747/1/src/target/firmware/apps/rssi/main.c 
File src/target/firmware/apps/rssi/main.c:

https://gerrit.osmocom.org/c/osmocom-bb/+/18747/1/src/target/firmware/apps/rssi/main.c@197 
PS1, Line 197: 		sprintf(text, "%c%cE%c%c", (power >= 40) ? 'D':'G',
Would be great using snprintf too.



-- 
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/18747
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I7980727b78f7622d792d82170f73c90ac5770397
Gerrit-Change-Number: 18747
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 09 Jun 2020 15:52:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200609/5836ada9/attachment.htm>


More information about the gerrit-log mailing list