Change in osmo-msc[master]: msc_a: add callref as call id to ASSIGNMENT REQ.

[dexter]

dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/18692 )

Change subject: msc_a: add callref as call id to ASSIGNMENT REQ.
......................................................................


Patch Set 2:

(2 comments)

> Patch Set 1:
> 
> I would prefer to merge the addition of this IE to all relevant messages (I wrote it in the osmcoom issue), but if you prefer we can also do one commit per command - but let's make sure we don't forget about other messages besides ASSIGNMENT CMD

I was having a look at the other messages now, I think its better to do it in separate commits.

https://gerrit.osmocom.org/c/osmo-msc/+/18692/1/src/libmsc/msc_a.c 
File src/libmsc/msc_a.c:

https://gerrit.osmocom.org/c/osmo-msc/+/18692/1/src/libmsc/msc_a.c@544 
PS1, Line 544: call_id_present = true,
             : 			.call_id = cc_trans->callref
> you are adding it unconditionally here. If we only support AoIP, we can do this unconditionally. […]
I think the sccplite support was only in the BSC. I have put it as an optional field because the spec has it optional, but in the end I think that hardcoding the presence flag everywhere in the end is also not a good idea.


https://gerrit.osmocom.org/c/osmo-msc/+/18692/1/src/libmsc/ran_msg_a.c 
File src/libmsc/ran_msg_a.c:

https://gerrit.osmocom.org/c/osmo-msc/+/18692/1/src/libmsc/ran_msg_a.c@1000 
PS1, Line 1000: 	if(ac->call_id_present)
> if if was a function... […]
Done



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/18692
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I4288f47e4a6d61ec672f431723f6e72c7c6b0799
Gerrit-Change-Number: 18692
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Tue, 09 Jun 2020 12:51:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200609/61f88b11/attachment.htm>