Change in osmo-bsc[master]: abis_rsl: Count successful channel requests

[laforge]

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18719 )

Change subject: abis_rsl: Count successful channel requests
......................................................................


Patch Set 1: Code-Review+1

I am sort-of undecided if this coulnter should be in the function that transmits an immediate assignment.   In the end, it is about successful processing of a channel request.

Yes, in reality, and particularly in the current code those two are the same.  However, I'm not sure if e.g. it would make sense at some point to re-transmit immediate assignments?  Or what about the immediate assignment without paging that the PCU does for tbf establishment in some states?  It maybe doesn't go thorugh this code path, but I'm trying to express why it feels a bit odd to me.

I'm not convinced it's much better inside the lchan_fsm where rsl_tx_imm_assignment() is called.  So maybe just leave it as-is but maybe put a comment on top explaining why we - at least so far - count here?


-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/18719
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I5c51956569223e802f4789dc5ed1605d18f80aea
Gerrit-Change-Number: 18719
Gerrit-PatchSet: 1
Gerrit-Owner: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 09 Jun 2020 11:05:55 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200609/9811116e/attachment.htm>