Change in libosmocore[master]: NS: Optionally disable NS-{RESET, BLOCK, UNBLOCK} when using UDP/IP

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Tue Jun 9 09:55:40 UTC 2020


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/18706 )

Change subject: NS: Optionally disable NS-{RESET,BLOCK,UNBLOCK} when using UDP/IP
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.osmocom.org/c/libosmocore/+/18706/2/src/gb/gprs_ns_vty.c 
File src/gb/gprs_ns_vty.c:

https://gerrit.osmocom.org/c/libosmocore/+/18706/2/src/gb/gprs_ns_vty.c@517 
PS2, Line 517: 		vty_nsi->nsip.use_reset_block_unblock = true;
> that returns a positive/negative integer, I prefer to keep it explicit. […]
Ok, but << !strcmp(argv[0], "enabled") >> doesn't return a negative/positive integer, since you are applying a boolean operator, it will return either 0 or (NOT 0), which is going to be 1, so one can assume false/true values.



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/18706
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ic4eba1b4dcbeac00f5879db295e0a9f1a50f71d8
Gerrit-Change-Number: 18706
Gerrit-PatchSet: 3
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 09 Jun 2020 09:55:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200609/451adc71/attachment.htm>


More information about the gerrit-log mailing list