Change in osmo-trx[master]: UHDDevice: Compute TxGain on UHD API based on expected Tx output power

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Tue Jun 9 07:42:46 UTC 2020


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/18723 )

Change subject: UHDDevice: Compute TxGain on UHD API based on expected Tx output power
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/c/osmo-trx/+/18723/2/Transceiver52M/device/uhd/UHDDevice.cpp 
File Transceiver52M/device/uhd/UHDDevice.cpp:

https://gerrit.osmocom.org/c/osmo-trx/+/18723/2/Transceiver52M/device/uhd/UHDDevice.cpp@216 
PS2, Line 216: tx_gain_db
if you subtract something from gain, then  it is attenuation.  I think we really should clean up the terminology here.  I'm completely confused at this point, to be honest - to the point I am unabl to review the code.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/18723
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I6f432465dce5c6ec1f1bc4653f6149efb18c3f43
Gerrit-Change-Number: 18723
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Tue, 09 Jun 2020 07:42:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200609/b0eb58a9/attachment.htm>


More information about the gerrit-log mailing list