Change in libosmo-abis[master]: e1_input: Initialize list struct

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Tue Jun 9 07:33:00 UTC 2020


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/18731 )

Change subject: e1_input: Initialize list struct
......................................................................


Patch Set 2: Code-Review-2

this is wrong.  INIT_LLIST_HEAD is *only* to be called on the "master" list to which siblings are added.  The cases you modify initialize a "slave" list entry that is added to a (properly initialized) master list (e1inp_line_list, e.g.).

If you ever miss a required INIT_LLIST_HEAD on a "master" list_head, then you will see a crash due to null pointer derefence the first time you try to use that.


-- 
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/18731
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: I850fdc43d597267aa66c6975aca9c1753231ac65
Gerrit-Change-Number: 18731
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Tue, 09 Jun 2020 07:33:00 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200609/2fbaa2d4/attachment.htm>


More information about the gerrit-log mailing list