Change in libosmocore[master]: NS: Optionally disable NS-{RESET, BLOCK, UNBLOCK} when using UDP/IP

[pespin]

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/18706 )

Change subject: NS: Optionally disable NS-{RESET,BLOCK,UNBLOCK} when using UDP/IP
......................................................................


Patch Set 2: Code-Review+1

(3 comments)

https://gerrit.osmocom.org/c/libosmocore/+/18706/2//COMMIT_MSG 
Commit Message:

https://gerrit.osmocom.org/c/libosmocore/+/18706/2//COMMIT_MSG@10 
PS2, Line 10: procedures shalle be used over an IP based transport.  They are only
typo: shall


https://gerrit.osmocom.org/c/libosmocore/+/18706/2/src/gb/gprs_ns.c 
File src/gb/gprs_ns.c:

https://gerrit.osmocom.org/c/libosmocore/+/18706/2/src/gb/gprs_ns.c@796 
PS2, Line 796: 			if (!nsvc->nsi->bss_sns_fi && nsvc->nsi->nsip.use_reset_block_unblock) {
YOu are using same check in several places. It may make sense to have a static inline function or define with those.


https://gerrit.osmocom.org/c/libosmocore/+/18706/2/src/gb/gprs_ns_vty.c 
File src/gb/gprs_ns_vty.c:

https://gerrit.osmocom.org/c/libosmocore/+/18706/2/src/gb/gprs_ns_vty.c@517 
PS2, Line 517: 		vty_nsi->nsip.use_reset_block_unblock = true;
vty_nsi->nsip.use_reset_block_unblock = !strcmp(argv[0], "enabled")



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/18706
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ic4eba1b4dcbeac00f5879db295e0a9f1a50f71d8
Gerrit-Change-Number: 18706
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 08 Jun 2020 08:45:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200608/496c8203/attachment.htm>