This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
neels gerrit-no-reply at lists.osmocom.orgneels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18505 ) Change subject: refactor bsc_find_msc()'s round-robin ...................................................................... Patch Set 4: > I don't agree with your point about using a number instead of a pointer because it's "safer". If that was the case, then we'd be dropping lots of pointers everywhere and using c++ with references or other programming language. > That being said, I'm not going to block this patch, so +1. well, keeping a number is in fact safer, because the msc with that number is free to go missing at any time without causing breakage. The difference is having *more than one* pointer to the same object that persist across main loops, which is always introducing the danger of segfaults. Where ever we do that, we need to carefully clean up: take a look at functions like lchan_forget_conn() and gscon_forget_lchan(), which act in a quite complex juxtaposition and are the final result of several levels of hard to crack segfault bugs I introduced before figuring out the current code. Thanks for the +1 :) -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/18505 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Idf71f07ba5a17d5b870dc1a5a2875b6fedb61291 Gerrit-Change-Number: 18505 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-CC: fixeria <vyanitskiy at sysmocom.de> Gerrit-Comment-Date: Sun, 07 Jun 2020 20:38:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200607/ea240968/attachment.htm>