Change in pysim[master]: Add support for ADF_USIM/EF_EHPLMN

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

guilly@gmail.com gerrit-no-reply at lists.osmocom.org
Sat Jun 6 20:26:56 UTC 2020


guilly at gmail.com has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/18649 )

Change subject: Add support for ADF_USIM/EF_EHPLMN
......................................................................


Patch Set 1:

(1 comment)

out of curiosity, the comment about the standard is interesting - so the EHPLMN list actually has priority to "void" the PLMN extracted from the IMSI in the PLMN search? I have seen MVNO SIMs, with the EHPLMN service enabled, but the list empty, what would be the HPLMN then?

https://gerrit.osmocom.org/c/pysim/+/18649/1/pySim/cards.py 
File pySim/cards.py:

https://gerrit.osmocom.org/c/pysim/+/18649/1/pySim/cards.py@82 
PS1, Line 82: 		(res, sw) = self._scc.read_binary(EF_USIM_ADF_map['EHPLMN'])
is it ok to put this USIM specific things in the generic Card class?

I was thinking in adding a "genericUSIM" card type, at the end of the card specific type list, to pack all the USIM specific things, wouldn't that be a tidier approach?

Also, are you OK by adding functions to read other fields, despite not being used in pySim-read? At the moment, I am using another script to read things like LOCI, PSLOCI, and others, not sure if submitting the change or not



-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/18649
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I22d96ab4a424ec5bc1fb02f5e80165c646a748d3
Gerrit-Change-Number: 18649
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: guilly at gmail.com <guilly at gmail.com>
Gerrit-Comment-Date: Sat, 06 Jun 2020 20:26:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200606/20c4415c/attachment.htm>


More information about the gerrit-log mailing list