Change in osmo-bts[master]: osmo-bts-trx/trx_if: fix memleak in trx_ctrl_cmd_cb()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

ipse gerrit-no-reply at lists.osmocom.org
Sat Jun 6 12:41:50 UTC 2020


ipse has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/18704 )

Change subject: osmo-bts-trx/trx_if: fix memleak in trx_ctrl_cmd_cb()
......................................................................


Patch Set 1:

(1 comment)

The patch looks valid to me but I'm no specialist in this part of the code.

I'm not sure whether this could fix the original issue with the leaking NOHANDOVER messages but happy to give it a try and see if this resolves the issue.

https://gerrit.osmocom.org/c/osmo-bts/+/18704/1/src/osmo-bts-trx/trx_if.c 
File src/osmo-bts-trx/trx_if.c:

https://gerrit.osmocom.org/c/osmo-bts/+/18704/1/src/osmo-bts-trx/trx_if.c@205 
PS1, Line 205:  *  The new ocommand will be added to the end of the control command
Minor suggestion - fix a typo in the comment here in a separate commit?



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/18704
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ie2cdf547befbc0fafdb82b10b45ad85a9b188b88
Gerrit-Change-Number: 18704
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: ipse <Alexander.Chemeris at gmail.com>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Sat, 06 Jun 2020 12:41:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200606/5a94d5b5/attachment.htm>


More information about the gerrit-log mailing list