Change in osmo-bsc[master]: stats: Count transitions from BORKEN state due to LCHAN_EV_TS_ERROR s...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

ipse gerrit-no-reply at lists.osmocom.org
Sat Jun 6 10:00:41 UTC 2020


ipse has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18703 )


Change subject: stats: Count transitions from BORKEN state due to LCHAN_EV_TS_ERROR signal.
......................................................................

stats: Count transitions from BORKEN state due to LCHAN_EV_TS_ERROR signal.

Change-Id: Ice3379020039dc3634aa3887939740729d720dee
---
M include/osmocom/bsc/gsm_data.h
M src/osmo-bsc/lchan_fsm.c
2 files changed, 9 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/03/18703/1

diff --git a/include/osmocom/bsc/gsm_data.h b/include/osmocom/bsc/gsm_data.h
index d2f6c09..e184adc 100644
--- a/include/osmocom/bsc/gsm_data.h
+++ b/include/osmocom/bsc/gsm_data.h
@@ -1416,6 +1416,7 @@
 	BTS_CTR_LCHAN_BORKEN_EV_RF_CHAN_REL_ACK,
 	BTS_CTR_LCHAN_BORKEN_EV_VTY,
 	BTS_CTR_LCHAN_BORKEN_EV_TEARDOWN,
+	BTS_CTR_LCHAN_BORKEN_EV_TS_ERROR,
 	BTS_CTR_TS_BORKEN_FROM_NOT_INITIALIZED,
 	BTS_CTR_TS_BORKEN_FROM_UNUSED,
 	BTS_CTR_TS_BORKEN_FROM_WAIT_PDCH_ACT,
@@ -1466,6 +1467,7 @@
 	[BTS_CTR_LCHAN_BORKEN_EV_RF_CHAN_REL_ACK] =       {"lchan_borken:event:rf_chan_rel_ack", "RF_CHAN_REL_ACK received in the lchan BORKEN state"},
 	[BTS_CTR_LCHAN_BORKEN_EV_VTY] =                   {"lchan_borken:event:vty", "VTY commands received in the lchan BORKEN state"},
 	[BTS_CTR_LCHAN_BORKEN_EV_TEARDOWN] =              {"lchan_borken:event:teardown", "lchan in a BORKEN state is shutting down (BTS disconnected?)"},
+	[BTS_CTR_LCHAN_BORKEN_EV_TS_ERROR] =              {"lchan_borken:event:ts_error", "LCHAN_EV_TS_ERROR received in a BORKEN state"},
 	[BTS_CTR_TS_BORKEN_FROM_NOT_INITIALIZED] =   {"ts_borken:from_state:not_initialized", "Transitions from TS NOT_INITIALIZED state to BORKEN state"},
 	[BTS_CTR_TS_BORKEN_FROM_UNUSED] =            {"ts_borken:from_state:unused", "Transitions from TS UNUSED state to BORKEN state"},
 	[BTS_CTR_TS_BORKEN_FROM_WAIT_PDCH_ACT] =     {"ts_borken:from_state:wait_pdch_act", "Transitions from TS WAIT_PDCH_ACT state to BORKEN state"},
diff --git a/src/osmo-bsc/lchan_fsm.c b/src/osmo-bsc/lchan_fsm.c
index a1bf857..1550ffb 100644
--- a/src/osmo-bsc/lchan_fsm.c
+++ b/src/osmo-bsc/lchan_fsm.c
@@ -1327,8 +1327,15 @@
 	switch (event) {
 
 	case LCHAN_EV_TS_ERROR:
+	{
+		struct gsm_lchan *lchan = lchan_fi_lchan(fi);
+		if (fi->state == LCHAN_ST_BORKEN) {
+			rate_ctr_inc(&lchan->ts->trx->bts->bts_ctrs->ctr[BTS_CTR_LCHAN_BORKEN_EV_TS_ERROR]);
+			osmo_stat_item_dec(lchan->ts->trx->bts->bts_statg->items[BTS_STAT_LCHAN_BORKEN], 1);
+		}
 		lchan_fail_to(LCHAN_ST_UNUSED, "LCHAN_EV_TS_ERROR");
 		return;
+	}
 
 	default:
 		return;

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/18703
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ice3379020039dc3634aa3887939740729d720dee
Gerrit-Change-Number: 18703
Gerrit-PatchSet: 1
Gerrit-Owner: ipse <Alexander.Chemeris at gmail.com>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200606/1598dfa9/attachment.htm>


More information about the gerrit-log mailing list