Change in osmo-bts[master]: common/scheduler: fix unreachable code in trx_sched_set_lchan()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Sat Jun 6 08:58:42 UTC 2020


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/18699 )

Change subject: common/scheduler: fix unreachable code in trx_sched_set_lchan()
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/c/osmo-bts/+/18699/2/src/common/scheduler.c 
File src/common/scheduler.c:

https://gerrit.osmocom.org/c/osmo-bts/+/18699/2/src/common/scheduler.c@a990 
PS2, Line 990: memset
Interesting that Coverity did not warn us about that. We basically memset() the whole structure, including both 'dl_bursts' and 'ul_bursts' pointers. And after that check if they're not NULL.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/18699
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ie9d8f8ca86195be4408db717cd3194a7d2ddc918
Gerrit-Change-Number: 18699
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Sat, 06 Jun 2020 08:58:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200606/039a8595/attachment.htm>


More information about the gerrit-log mailing list