This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
dexter gerrit-no-reply at lists.osmocom.orgdexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/18694 ) Change subject: gsm0808: fix endieness of call identifier ...................................................................... Patch Set 1: > Patch Set 1: > > I'm not convinced (yet). Normally, we pass values around in host byte order and only translate them to network byte order when generating messages. > > So why is that value already in netwokr byte order? Why can the caller not provide it in host byte order? > > Also, if we really want function arguments are not in native (host) byte order, I think it must clearly be documented in the doxygen part. Hmm. I have checked it multiple times now. Network byte order is big endien, x86er is little endien. However 3GPP TS 48.008, section 3.2.2.105 wants the least significant byte transmitted first. I think thats why the endieness should already match the host byte order here. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/18694 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I6468e502f552f99ab54aec9d4b1c169fdc0adfb8 Gerrit-Change-Number: 18694 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier at sysmocom.de> Gerrit-CC: laforge <laforge at osmocom.org> Gerrit-CC: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Fri, 05 Jun 2020 16:55:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200605/c129fa80/attachment.htm>