Change in osmo-bts[master]: vty: use gsm48_chan_mode_name() from libosmocore

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Thu Jun 4 22:20:07 UTC 2020


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/18666 )

Change subject: vty: use gsm48_chan_mode_name() from libosmocore
......................................................................

vty: use gsm48_chan_mode_name() from libosmocore

Change-Id: I18cdaa26a674bd9279a4ea1946aefc6969404139
---
M src/common/vty.c
1 file changed, 1 insertion(+), 14 deletions(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved



diff --git a/src/common/vty.c b/src/common/vty.c
index d94a927..a57f3b5 100644
--- a/src/common/vty.c
+++ b/src/common/vty.c
@@ -1106,19 +1106,6 @@
 	return CMD_SUCCESS;
 }
 
-/* FIXME: move this to libosmogsm */
-static const struct value_string gsm48_cmode_names[] = {
-	{ GSM48_CMODE_SIGN,		"signalling" },
-	{ GSM48_CMODE_SPEECH_V1,	"FR or HR" },
-	{ GSM48_CMODE_SPEECH_EFR,	"EFR" },
-	{ GSM48_CMODE_SPEECH_AMR,	"AMR" },
-	{ GSM48_CMODE_DATA_14k5,	"CSD(14k5)" },
-	{ GSM48_CMODE_DATA_12k0,	"CSD(12k0)" },
-	{ GSM48_CMODE_DATA_6k0,		"CSD(6k0)" },
-	{ GSM48_CMODE_DATA_3k6,		"CSD(3k6)" },
-	{ 0, NULL }
-};
-
 /* call vty_out() to print a string like " as TCH/H" for dynamic timeslots.
  * Don't do anything if the ts is not dynamic. */
 static void vty_out_dyn_ts_status(struct vty *vty, struct gsm_bts_trx_ts *ts)
@@ -1185,7 +1172,7 @@
 		ms_pwr_dbm(lchan->ts->trx->bts->band, lchan->ms_power_ctrl.max),
 		VTY_NEWLINE);
 	vty_out(vty, "  Channel Mode / Codec: %s%s",
-		get_value_string(gsm48_cmode_names, lchan->tch_mode),
+		gsm48_chan_mode_name(lchan->tch_mode),
 		VTY_NEWLINE);
 
 	if (lchan->abis_ip.bound_ip) {

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/18666
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I18cdaa26a674bd9279a4ea1946aefc6969404139
Gerrit-Change-Number: 18666
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200604/b5a6b354/attachment.htm>


More information about the gerrit-log mailing list