Change in pysim[master]: commands.py: fix read_binary for lengths > 256

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Wed Jun 3 20:57:37 UTC 2020


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/17848 )

Change subject: commands.py: fix read_binary for lengths > 256
......................................................................


Patch Set 8:

> I got a couple of SIMs with the PLMN lists with 300 bytes. I am happy to add the test if needed, is just that I was told this is tested with real HW only?

At sysmocom, we can create a SIM card profile card with larger files for our test environment.   It would just be good if we don't create a completely artificial test, but reproduce something that you actually saw on real SIM Cards.  So if you can make it work on your side and send us some APDU logs, and/or even the related test - great.  we then simply create a SIM card with the same-sized file and identical content here.


-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/17848
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ie9c61caa1412606254b44a3a24f26ad44950e73a
Gerrit-Change-Number: 17848
Gerrit-PatchSet: 8
Gerrit-Owner: guilly at gmail.com <guilly at gmail.com>
Gerrit-Assignee: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: guilly at gmail.com <guilly at gmail.com>
Gerrit-CC: dexter <pmaier at sysmocom.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Wed, 03 Jun 2020 20:57:37 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200603/cbc6b02f/attachment.htm>


More information about the gerrit-log mailing list