This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
neels gerrit-no-reply at lists.osmocom.orgneels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18501 ) Change subject: CTRL: determine MSC connection status from RESET-ACK, not AS_ACTIVE ...................................................................... CTRL: determine MSC connection status from RESET-ACK, not AS_ACTIVE Change-Id: I264ba6a72ea93297cfbc99602eccfbf4a890f703 --- M src/osmo-bsc/osmo_bsc_ctrl.c 1 file changed, 2 insertions(+), 10 deletions(-) Approvals: neels: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/osmo-bsc/osmo_bsc_ctrl.c b/src/osmo-bsc/osmo_bsc_ctrl.c index 12b2f4d..b94a749 100644 --- a/src/osmo-bsc/osmo_bsc_ctrl.c +++ b/src/osmo-bsc/osmo_bsc_ctrl.c @@ -26,6 +26,7 @@ #include <osmocom/bsc/osmo_bsc_rf.h> #include <osmocom/bsc/bsc_msc_data.h> #include <osmocom/bsc/signal.h> +#include <osmocom/bsc/a_reset.h> #include <osmocom/core/linuxlist.h> #include <osmocom/core/signal.h> @@ -179,21 +180,12 @@ static int get_msc_connection_status(struct ctrl_cmd *cmd, void *data) { struct bsc_msc_data *msc = (struct bsc_msc_data *)cmd->node; - struct osmo_ss7_as *as; - const char *as_state_name; if (msc == NULL) { cmd->reply = "msc not found"; return CTRL_CMD_ERROR; } - as = msc_get_ss7_as(msc); - if (!as) { - cmd->reply = "AS not found for MSC"; - return CTRL_CMD_ERROR; - } - - as_state_name = osmo_fsm_inst_state_name(as->fi); - if (!strcmp(as_state_name, "AS_ACTIVE")) + if (a_reset_conn_ready(msc)) cmd->reply = "connected"; else cmd->reply = "disconnected"; -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/18501 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I264ba6a72ea93297cfbc99602eccfbf4a890f703 Gerrit-Change-Number: 18501 Gerrit-PatchSet: 5 Gerrit-Owner: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200603/9a886b0a/attachment.htm>