This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
neels gerrit-no-reply at lists.osmocom.orgneels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/18506 ) Change subject: add gsm23236: MSC pooling: TMSI and NRI utility functions ...................................................................... Patch Set 4: (1 comment) https://gerrit.osmocom.org/c/libosmocore/+/18506/2/src/gsm/gsm23236.c File src/gsm/gsm23236.c: https://gerrit.osmocom.org/c/libosmocore/+/18506/2/src/gsm/gsm23236.c@36 PS2, Line 36: int16_t > The function itself returns an error code: […] whether this function fails or not is a separate aspect of whether, say, osmo-bsc's VTY config wants to indicate that a stored nri_v is invalid or not. For example, we may need to configure a separate NULL-NRI for each MSC. If I want to indicate in the config that some MSC has no NULL-NRI configured, I can set it negative (or need a separate bool). So I choose to have negative NRI to indicate invalid, and then of course I want to have one consistent data type everywhere. We can also use uint16_t with a #define OSMO_NRI_INVALID, if you prefer that, but using a signed integer is less code. Or I could add 'typedef int16_t osmo_nri_v'? Before, I had the nri_v as return value, being negative on error, but some review didn't like that. It is IMHO also nicer with a separate return value, consistently for both this and osmo_tmsi_nri_set(). So I will not go back to returning the nri_v. re "confusing": the api doc explains everything, which part do you find confusing? Should I add "is always positive" to the 'nri_v' api doc? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/18506 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Icb57a2dd9323c7ea11b34003eccc7e68a0247bf5 Gerrit-Change-Number: 18506 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de> Gerrit-CC: Vadim Yanitskiy <vyanitskiy at sysmocom.de> Gerrit-CC: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Wed, 03 Jun 2020 14:20:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Vadim Yanitskiy <vyanitskiy at sysmocom.de> Comment-In-Reply-To: neels <nhofmeyr at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200603/5353e75b/attachment.htm>