Change in osmo-bts[master]: Do not mix public and private BTS features, use libosmocore's API

[neels]

neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/18591 )

Change subject: Do not mix public and private BTS features, use libosmocore's API
......................................................................


Patch Set 6: Code-Review+1

(5 comments)

only cosmetics...
mostly about the term choice of "implementation".
Did you mean "internal"? "BTS-model" / "BTS-type"?

https://gerrit.osmocom.org/c/osmo-bts/+/18591/6/include/osmo-bts/gsm_data_shared.h 
File include/osmo-bts/gsm_data_shared.h:

https://gerrit.osmocom.org/c/osmo-bts/+/18591/6/include/osmo-bts/gsm_data_shared.h@461 
PS6, Line 461: /* BTS implementation flags (internal use, not exposed via OML) */
(so maybe reflect "internal" in the naming? bts_internal_flag_get(), bts_internal_flag_set()?)


https://gerrit.osmocom.org/c/osmo-bts/+/18591/6/include/osmo-bts/gsm_data_shared.h@465 
PS6, Line 465: 	(bts->flags |= (typeof(bts->flags)) flag)
(braces around this are slightly weird)


https://gerrit.osmocom.org/c/osmo-bts/+/18591/6/include/osmo-bts/gsm_data_shared.h@468 
PS6, Line 468: #define BTS_IMPL_FLAG_MS_PWR_CTRL_DSP		(1 << 0)
( s/IMPL/INTERNAL/ ?)


https://gerrit.osmocom.org/c/osmo-bts/+/18591/6/src/common/vty.c 
File src/common/vty.c:

https://gerrit.osmocom.org/c/osmo-bts/+/18591/6/src/common/vty.c@832 
PS6, Line 832: 	for (i = 0, no_features = true; i < _NUM_BTS_FEAT; i++) {
(I'd rather leave the 'no_features = true' at the start of the function, above. This looks like no_features is used as a loop condition; it does not affect the loop, only what happens around the loop. So it doesn't qualify as a start condition, really.)


https://gerrit.osmocom.org/c/osmo-bts/+/18591/6/src/common/vty.c@843 
PS6, Line 843: 	vty_out(vty, "  Implementation flags:%s", VTY_NEWLINE);
"Implementation" is a very general term, basically all code is implementation. In the comments you used "internal flags", which I find easier to understand... or "BTS model specific flags"?



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/18591
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Icf792d02323bb73e3b8d46384c7890cb1eb4731e
Gerrit-Change-Number: 18591
Gerrit-PatchSet: 6
Gerrit-Owner: Vadim Yanitskiy <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 02 Jun 2020 12:40:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200602/2da3d350/attachment.htm>