Change in libosmocore[master]: vty: Introduce support to set cpu-affinity and scheduler policy

[laforge]

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/19442 )

Change subject: vty: Introduce support to set cpu-affinity and scheduler policy
......................................................................


Patch Set 4:

(4 comments)

https://gerrit.osmocom.org/c/libosmocore/+/19442/4/src/vty/sched_vty.c 
File src/vty/sched_vty.c:

https://gerrit.osmocom.org/c/libosmocore/+/19442/4/src/vty/sched_vty.c@112 
PS4, Line 112: parse_cpu_hex_mask
might be a candidate for a unit test? (also the encoder)


https://gerrit.osmocom.org/c/libosmocore/+/19442/4/src/vty/sched_vty.c@259 
PS4, Line 259: 				buf
I think this still has the buffer overflow problem I mentioned in my review of the previous patch.  rc could be sizeof(buf), and you're accessing buffer beyond its end.


https://gerrit.osmocom.org/c/libosmocore/+/19442/4/src/vty/sched_vty.c@353 
PS4, Line 353: {
             : 		return -EINVAL;
             : 	}
cosmetic: no curly braces needed


https://gerrit.osmocom.org/c/libosmocore/+/19442/4/src/vty/sched_vty.c@499 
PS4, Line 499: sched
sorry for noticing only now: I think this should be named 'cpu-sched' or the like.  As GSM is a TDMA system, there may be all kinds of schedulers, and it would probably be best to clearly recognize this one.  Not critical, but I think now is the time to fix it - after it's merged, we cannot touch naming.



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/19442
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: If76a4bd2cc7b3c7adf5d84790a944d78be70e10a
Gerrit-Change-Number: 19442
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 30 Jul 2020 20:43:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200730/efa12ee1/attachment.htm>