Change in osmo-ttcn3-hacks[master]: CCID_Tests: Ensure the response to "SELET MF" is two bytes (SW) long

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Thu Jul 30 20:32:34 UTC 2020


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19465 )

Change subject: CCID_Tests: Ensure the response to "SELET MF" is two bytes (SW) long
......................................................................

CCID_Tests: Ensure the response to "SELET MF" is two bytes (SW) long

we used to accept arbitrary length responses, which made us fail to
catch the bug described in OS#4684

Change-Id: I35721ce55b58a2f70ea30a0d1bd16d2ac58dfcab
Related: OS#4684
---
M ccid/CCID_Tests.ttcn
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  laforge: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/ccid/CCID_Tests.ttcn b/ccid/CCID_Tests.ttcn
index c620b0b..2256025 100644
--- a/ccid/CCID_Tests.ttcn
+++ b/ccid/CCID_Tests.ttcn
@@ -379,7 +379,7 @@
 	f_ccid_power_on();
 	f_ccid_set_par(ts_ProtoDataT0(ISO7816_FI_512_5MHz, ISO7816_DI_32));
 	for (i := 0; i < 1000; i := i+1) {
-		f_ccid_xfr(c_UICC_SELECT_MF, ?);
+		f_ccid_xfr(c_UICC_SELECT_MF, '??'O);
 	}
 }
 testcase TC_select_mf() runs on Test_CT

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19465
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I35721ce55b58a2f70ea30a0d1bd16d2ac58dfcab
Gerrit-Change-Number: 19465
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200730/9d05f5f1/attachment.htm>


More information about the gerrit-log mailing list