Change in libosmocore[master]: gsm0411_{smc, smr}.c: Work around newlib bug

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Thu Jul 30 19:52:44 UTC 2020


laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/19462 )

Change subject: gsm0411_{smc,smr}.c: Work around newlib bug
......................................................................

gsm0411_{smc,smr}.c: Work around newlib bug

At least on Debian unstable, newlib is [currently?] buggy in that
we need to include sys/types.h before including inttypes.h, otherwise
PRIu64 is not defined.

Change-Id: Ic1c9cdf66cfd5b82bd7e20eaaf05b10e6bdb675e
Closes: OS#4686
---
M src/gsm/gsm0411_smc.c
M src/gsm/gsm0411_smr.c
2 files changed, 4 insertions(+), 2 deletions(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved



diff --git a/src/gsm/gsm0411_smc.c b/src/gsm/gsm0411_smc.c
index 50d0f3e..a7d5e11 100644
--- a/src/gsm/gsm0411_smc.c
+++ b/src/gsm/gsm0411_smc.c
@@ -51,8 +51,9 @@
  *
  */
 
-#include <string.h>
+#include <sys/types.h>
 #include <inttypes.h>
+#include <string.h>
 #include <errno.h>
 #include <osmocom/core/msgb.h>
 #include <osmocom/core/logging.h>
diff --git a/src/gsm/gsm0411_smr.c b/src/gsm/gsm0411_smr.c
index 21d28c5..02b4199 100644
--- a/src/gsm/gsm0411_smr.c
+++ b/src/gsm/gsm0411_smr.c
@@ -49,9 +49,10 @@
  */
 
 
+#include <sys/types.h>
+#include <inttypes.h>
 #include <string.h>
 #include <errno.h>
-#include <inttypes.h>
 #include <osmocom/core/msgb.h>
 #include <osmocom/core/logging.h>
 #include <osmocom/core/timer.h>

-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/19462
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ic1c9cdf66cfd5b82bd7e20eaaf05b10e6bdb675e
Gerrit-Change-Number: 19462
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200730/5f6ec7c5/attachment.htm>


More information about the gerrit-log mailing list