Change in osmocom-bb[master]: layer23/mobile: fix a memory leak (msgb) in gsm48_rr_data_ind()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Thu Jul 30 09:47:02 UTC 2020


fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/19454 )


Change subject: layer23/mobile: fix a memory leak (msgb) in gsm48_rr_data_ind()
......................................................................

layer23/mobile: fix a memory leak (msgb) in gsm48_rr_data_ind()

Change-Id: I55dcccf5b7d27d012908759954182eaec434d26b
---
M src/host/layer23/src/mobile/gsm48_rr.c
1 file changed, 3 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/54/19454/1

diff --git a/src/host/layer23/src/mobile/gsm48_rr.c b/src/host/layer23/src/mobile/gsm48_rr.c
index 74b94c4..0449ee3 100644
--- a/src/host/layer23/src/mobile/gsm48_rr.c
+++ b/src/host/layer23/src/mobile/gsm48_rr.c
@@ -4633,8 +4633,10 @@
 		uint8_t skip_ind = (gh->proto_discr & 0xf0) >> 4;
 
 		/* ignore if skip indicator is not B'0000' */
-		if (skip_ind)
+		if (skip_ind) {
+			msgb_free(msg);
 			return 0;
+		}
 
 		switch(gh->msg_type) {
 		case GSM48_MT_RR_ADD_ASS:

-- 
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/19454
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I55dcccf5b7d27d012908759954182eaec434d26b
Gerrit-Change-Number: 19454
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200730/6d46a6b9/attachment.htm>


More information about the gerrit-log mailing list